GnuCash
Contact   Instructions
Bug 798327 - Ofx import stops too early for multi-account OFX and one account has no new transactions
Summary: Ofx import stops too early for multi-account OFX and one account has no new t...
Status: RESOLVED FIXED
Alias: None
Product: GnuCash
Classification: Unclassified
Component: Import - OFX (show other bugs)
Version: 4.8
Hardware: PC Mac OS
: Normal normal
Target Milestone: ---
Assignee: import
QA Contact: import
URL:
Whiteboard:
Keywords:
: 798384 798404 (view as bug list)
Depends on:
Blocks:
 
Reported: 2021-10-03 23:40 EDT by Jean Laroche
Modified: 2022-07-16 17:16 EDT (History)
8 users (show)

See Also:

Attachments
Account used to demonstrate the issue (10.10 KB, application/octet-stream)
2021-10-03 23:40 EDT, Jean Laroche 		no flags Details
Ofx file used to demonstrate the issue. (55.10 KB, text/plain)
2021-10-03 23:41 EDT, Jean Laroche 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Description Jean Laroche 2021-10-03 23:40:50 EDT 
Created attachment 374206 [details]
Account used to demonstrate the issue

This was reported by Robin. The gist of it is that when importing an OFX file that has multiple target accounts (typically the case for securities) and an account has no transactions to match, the import process terminates prematurely without continuing to import transactions for all other accounts.

Attached are a test account and ofx that demonstrate the problem.
Comment 1 Jean Laroche 2021-10-03 23:41:48 EDT 
Created attachment 374207 [details]
Ofx file used to demonstrate the issue.
Comment 2 Jean Laroche 2021-10-03 23:43:42 EDT 
I debugged this and the issue is the info->response does not show "OK" when there are no transactions to review, so GC wrongly assumes the user pressed "CANCEL". The fix is simply to set info->response to the right value in that case.
Comment 3 Jean Laroche 2021-10-03 23:48:26 EDT 
Created PR https://github.com/Gnucash/gnucash/pull/1159 to fix this issue.
Comment 4 Robin Chattopadhyay 2021-10-04 19:26:51 EDT 
This fix worked for me. I also was able to complete all the steps I originally performed, this time the process worked to completion.
Comment 5 Chris Good 2021-10-12 19:28:10 EDT 
Fix PR 1159 merged into maint 13/10/2021, will be in GnuCash 4.9 planned release 2021-12-19. Thanks Jean.
Comment 6 Vincent Smeets 2021-12-11 05:44:27 EST 
*** Bug 798384 has been marked as a duplicate of this bug. ***
Comment 7 John Ralls 2022-07-16 17:16:02 EDT 
*** Bug 798404 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.