GnuCash
Contact   Instructions
Bug 798226 - minor mistakes in Tutorial and Concepts guide 2
Summary: minor mistakes in Tutorial and Concepts guide 2
Status: RESOLVED FIXED
Alias: None
Product: Documentation
Classification: Unclassified
Component: Guide (show other bugs)
Version: git-maint
Hardware: PC All
: Normal minor
Target Milestone: ---
Assignee: documentation
QA Contact: documentation
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-07-03 06:04 EDT by TANIGUCHI Yasuaki
Modified: 2021-07-07 11:16 EDT (History)
4 users (show)

See Also:


Attachments
fix typos, spaces and tags patch (9.27 KB, application/octet-stream)
2021-07-03 06:06 EDT, TANIGUCHI Yasuaki
no flags Details
fix typos, spaces and tags patch (9.27 KB, patch)
2021-07-03 06:08 EDT, TANIGUCHI Yasuaki
yasuakit: needs-work+
frank.h.ellenberger: committed+
Details

Description TANIGUCHI Yasuaki 2021-07-03 06:04:41 EDT
I found some mistakes in the Tutorial and Concepts guide.
Comment 1 TANIGUCHI Yasuaki 2021-07-03 06:06:00 EDT
Created attachment 374114 [details]
fix typos, spaces and tags patch

This patch will fix some mistakes in basics and transactions
Comment 2 TANIGUCHI Yasuaki 2021-07-03 06:08:17 EDT
Created attachment 374115 [details]
fix typos, spaces and tags patch

This patch will fix some mistakes in basics and transactions.
I changed MIME type.
Comment 3 TANIGUCHI Yasuaki 2021-07-06 02:28:18 EDT
Comment on attachment 374115 [details]
fix typos, spaces and tags patch

I need to work more to create a patch file, because I found other mistakes.
Comment 4 Frank H. Ellenberger 2021-07-06 08:48:45 EDT
Comment on attachment 374115 [details]
fix typos, spaces and tags patch

Thanks, I had already committed it last night as 15219e3.

BTW it is less work for me, if you create pull requests instead of bugzilla patches.

Some changes in ch_basics.xml were wrong because there is currently something wrong in our xmlformat.conf: In normal text we want spaces around menuchoice, but in some cases (brackets, start or end of sentence) not. Until now I found no way to get both forms. Currently it is removing the spaces.

Another note: Help has a more recent version of the transactions chapter. We still have to decide, where to remove the redundancy.

How do you prefer to continue? I would prefer closing this bug and create pull requests for the remaining parts, but that is up to you.
Comment 5 TANIGUCHI Yasuaki 2021-07-06 18:53:37 EDT
Thank you for accepting my patch.

> BTW it is less work for me, if you create pull requests instead 
> of bugzilla patches.

I see. I will switch GitHub's pull request. So please close this bug id.
Comment 6 TANIGUCHI Yasuaki 2021-07-06 19:25:26 EDT
>Another note: Help has a more recent version of the transactions chapter. We
> still have to decide, where to remove the redundancy.

I'm working against the fixed 4.6 tag of Concepts Guide right now. And changes on maint branch don't directly affect me. I will bump up the version if necessary. So you don't need to take care of my translation progress.
Comment 7 John Ralls 2021-07-06 23:04:44 EDT
For pull requests you pretty much need to work with a git clone because you need to make a git branch in your github repo at which to point the pull request. If you're not familiar with git our https://wiki.gnucash.org/wiki/Git page is a good place to start.
Comment 8 Frank H. Ellenberger 2021-07-07 11:16:45 EDT
Thanks!

Note You need to log in before you can comment on or make changes to this bug.