GnuCash
Contact   Instructions
Bug 798212 - right-click the down-arrow in the date register changes focus to first split
Summary: right-click the down-arrow in the date register changes focus to first split
Status: RESOLVED FIXED
Alias: None
Product: GnuCash
Classification: Unclassified
Component: Register (show other bugs)
Version: git-maint
Hardware: PC All
: Normal minor
Target Milestone: ---
Assignee: ui
QA Contact: ui
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-06-19 21:34 EDT by Christopher Lam
Modified: 2021-06-21 06:23 EDT (History)
3 users (show)

See Also:


Attachments
Register toggle button patch (3.52 KB, patch)
2021-06-20 07:47 EDT, Bob
no flags Details

Description Christopher Lam 2021-06-19 21:34:54 EDT
Minor UI niggle; from the register, right-click the date-cell down-arrow.

In some prior commit <1 month ago it would cause a crash after several right-clicks, but seems to have been fixed recently. Now it simply jumps unexpectedly to the first split.

Expected: right-click is ignored.
Comment 1 Bob 2021-06-20 07:47:45 EDT
Created attachment 374089 [details]
Register toggle button patch

Chris, can you give this patch a spin and see if it fixes your issue.
Comment 2 Christopher Lam 2021-06-20 10:21:52 EDT
Seems to work. But I'm not sure whether it's better to disable button3, or respond only to button1.
Comment 3 Bob 2021-06-21 06:23:30 EDT
Chris, The item_edit which comprises of a GtkEntry and a GtkToggleButon are effectively sitting on top pf the register sheet. The sheet has it own button press function that deals with the right mouse to present the menu. If the toggle button does not deal with the right mouse event it is passed up the chain and so the sheet deals with it. To prevent that, the toggle button needs to effectively say it has dealt with it and so will not pass on up.

Have pushed my fix and will be in the next nightly and version 4.6

Note You need to log in before you can comment on or make changes to this bug.