GnuCash
Contact   Instructions
Bug 798096 - can't duplicate tx previous to red line threshold
Summary: can't duplicate tx previous to red line threshold
Status: RESOLVED FIXED
Alias: None
Product: GnuCash
Classification: Unclassified
Component: Register (show other bugs)
Version: 4.4
Hardware: PC All
: Normal normal
Target Milestone: ---
Assignee: ui
QA Contact: ui
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-01-23 08:32 EST by Wm
Modified: 2021-02-14 08:05 EST (History)
4 users (show)

See Also:


Attachments

Description Wm 2021-01-23 08:32:58 EST
before 4.3 it was possible to duplicate a tx previous to the red-line threshold

tx previous to the threshold are only read-only to prevent finger mistakes as opposed to their status or similar making them read-only, it is easy to test this by changing the threshold to 0 and doing the duplication regardless

this was possibly introduced inadvertently in (I'm guessing) 645379 or 798031 so I don't know if this is NEW, REOPEN, something else

work around: just change the
File / Properties / Threshold
setting to 0, do your duplication, then put it back to whatever it was (I use 27)

I duplicate tx frequently so I'm not sure if anything else was affected; it is still possible to Copy and Paste a pre-threshold tx and create a SX from one which is why I think this might be an artefact rather than intended.
Comment 1 Bob 2021-01-24 10:34:58 EST
I will look at this.
Comment 2 Wm 2021-01-26 08:56:09 EST
@Bob: thank you.

@all, I had a quick look back at the text (hover description? not sure of the name) associated with the threshold / readonly-days value and it hasn't changed since at least 2012 (so it is probably older given my not in-depth search attempt) and says:

"Choose the number of days after which transactions will be read-only and cannot be edited anymore.  This threshold is marked by a red line in the account register windows.  If zero, all transactions can be edited and none are read-only."

It occurs to me that the text might need tidying up as it doesn't really describe what the number in the field is for or doing.  There is certainly no change to any tx when the number is changed, it is just a convenience.

Also, it seems to have an upper limit of approximately 10 years, I can't get the field to accept a number larger than 3650 although 0 is effectively forever or never for this particular setting.

To be clear, I like and value the setting and use it and actually insist on it being used in places where new people might be entering tx but:

is the hover description accurate? I think not, but I never really thought about it before as I was using it previous to 2012 or whenever the description got introduced.

So, I don't think this should be a "book option", I think it should be under

Edit / Preferences / Register

OR

Edit / Preferences / Register defaults

I have a mild preference for "Register defaults" but I'm not going to cry so long as it is moved to Edit / Preferences where it belongs.

In case anyone is wondering, the setting we are talking about *DOES NOT AFFECT THE BOOK* so shouldn't be under Book Options.  Apols for rant but putting "Use trading accounts" which *IS* significant to a book next to the cosmetic read-only threshold is not sensible.
Comment 3 Wm 2021-01-26 09:44:29 EST
P.S. I think some changes wrt the *BOOK SIGNIFICANT* Split Action Field have had unexpected consequences.

I am not saying Bob made the changes, I am pointing out the difference between book significance and cosmetic register changes.  

The Num / Action / whatever field is so over used as a result of the wait for a real db design it has been used for so many fucking things it is near useless :(
Comment 4 Wm 2021-01-26 09:54:05 EST
Any time anyone touches it something will go wrong for someone.

GET ON WITH THE DB WORK, I say.
Comment 5 Bob 2021-02-13 06:25:43 EST
I have pushed a fix for the disabled transaction duplication, this was mistakenly disabled by me in a previous commit.

This fix will be in the next release 4.5 and the next nightly.

Regarding the other issues mentioned, please separate out to separate bugs. I know there was talk about reviewing all settings at some point so maybe the tooltip can be changed then if necessary.

I am closing this as I have confirmed original bug and fix.
Comment 6 Wm 2021-02-14 08:05:03 EST
Thank you, Bob; if the previous behaviour is back I am happy for this to be marked  closed, resolved, fixed, etc.

I'll see if I can find the review you mentioned and contribute to that thread.

Note You need to log in before you can comment on or make changes to this bug.