Longstanding minor UI issue: * Edit > Style Sheets * Choose any stylesheet * Click Edit button This opens the stylesheet editor; * Click Cancel Focus returns to toplevel GnuCash window instead of the stylesheet selector. Minor issue, but somewhat annoying. Fixer would help me fix similar bugs in the future.
I will have a look at this this week.
This may not be easily reproducible other than my setup. But this does show up both on my Ubuntu and Windows.
Chris pushed my change for this to maint. From testing the transient parent seemed to be correct but had started a patch to change this GtkDialog to a GtkWindow previously so decided to complete that. Please check it works OK for you.
Bob, what's your motivation to change the style sheet editor into a GtkWindow ? What are the issues other than the wrong transient parent you intend to fix with this ?
From my pov this is now fixed and this bug could be closed, thanks! I guess Geert is asking from a technical perspective the reasoning for window vs dialog.
Geert, I was looking at another couple of bugs 797637 and 797682 awhile back and got side tracked when I looked at the style sheet editor. On Windows10, GtkDialogs calling GtkDialogs do not respond to the windows shortcuts (<windows key><m> and <windows key><shift><m>), bug797682, the second dialog may not minimize. Also if Gnucash is swapped out with another application and then switched back there is the potential the dialog may be come unreachable, bug797637 demonstrates this but I think I had that on the 'Sales Tax Table' before I changed that. So to me, having a GtkWindow call a GtkDialog is presented more reliably and try to avoid cascading GtkDialogs unless the second one is something simple like an entry, or a couple of buttons but mainly the second dialog should not need to be swapped out. For bug797637, that are three cascading GtkDialogs. I had it in my mind to change that to a GtkWindow and one GtkDialog but still thinking how to combine the second two dialogs, maybe use a GtkRevealer. Hope this makes sense.
