GnuCash
Contact   Instructions
Bug 797873 - New Account Hierarchy Setup selects en_US language/region template categories
Summary: New Account Hierarchy Setup selects en_US language/region template categories
Status: RESOLVED FIXED
Alias: None
Product: GnuCash
Classification: Unclassified
Component: User Interface General (show other bugs)
Version: 4.0
Hardware: PC Linux
: Normal normal
Target Milestone: ---
Assignee: ui
QA Contact: ui
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-07-24 22:16 EDT by YOSHINO Yoshihito
Modified: 2020-07-28 01:05 EDT (History)
5 users (show)

See Also:

Attachments
patch (896 bytes, patch)
2020-07-24 22:16 EDT, YOSHINO Yoshihito 		no flags Details
symptom (197.70 KB, image/png)
2020-07-24 22:20 EDT, YOSHINO Yoshihito 		no flags Details
patch (896 bytes, patch)
2020-07-24 22:21 EDT, YOSHINO Yoshihito 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Description YOSHINO Yoshihito 2020-07-24 22:16:43 EDT 
Created attachment 373800 [details]
patch

Steps to reproduce:

Open "New Accout Hierarchy Setup"
Go to page "Choose accounts to create" 
"Categories" combo boxes are set to "en" "US"

Expected:

Open "New Accout Hierarchy Setup"
Go to page "Choose accounts to create"
"Categories" combo boxes are set based the current LANG.

Note that selected templates looks good, based on the current LANG.



The attached patch should fix this problem.
Comment 1 YOSHINO Yoshihito 2020-07-24 22:20:06 EDT 
Created attachment 373801 [details]
symptom
Comment 2 YOSHINO Yoshihito 2020-07-24 22:21:04 EDT 
Created attachment 373802 [details]
patch
Comment 3 YOSHINO Yoshihito 2020-07-24 22:33:52 EDT 
update_language_region_combos traverses each directory entry in the gnc_path_get_accountsdir.
When it hits "C" directory it unconditionally overwrites start_region variable which is used to determine the default language/region.
Comment 4 Bob 2020-07-25 06:42:06 EDT 
Thank you for the patch, I have pushed the changes to maint and will be included in the next release 4.1 which should be this weekend.
Comment 5 John Ralls 2020-07-28 01:05:09 EDT 
Yoshino-san could I enlist your help with bug 797860? I don't have access to a 106-key keyboard and I don't understand where GnuCash could be causing the symptoms described.
Note You need to log in before you can comment on or make changes to this bug.