GnuCash
Contact   Instructions
Bug 797828 - Budget Barchart was not upgraded
Summary: Budget Barchart was not upgraded
Status: RESOLVED FIXED
Alias: None
Product: GnuCash
Classification: Unclassified
Component: Reports (show other bugs)
Version: 4.0
Hardware: PC Mac OS
: Normal major
Target Milestone: ---
Assignee: Christopher Lam
QA Contact: reports
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-06-29 22:23 EDT by Peter Kane
Modified: 2020-07-05 00:55 EDT (History)
3 users (show)

See Also:


Attachments
V4.0 budget graph (381.38 KB, image/png)
2020-06-30 01:45 EDT, Peter Kane
no flags Details
V3.10 budget graph, same data. (499.62 KB, image/png)
2020-06-30 01:46 EDT, Peter Kane
no flags Details
Budget report (1.11 MB, image/png)
2020-06-30 06:51 EDT, Peter Kane
no flags Details
budget-barchart.scm (13.44 KB, text/plain)
2020-06-30 08:15 EDT, Christopher Lam
no flags Details
erm use this one instead (13.47 KB, text/plain)
2020-06-30 08:30 EDT, Christopher Lam
no flags Details

Description Peter Kane 2020-06-29 22:23:19 EDT
I installed 4.0, and my budget reports were missing data. I've gone back to 3.10, because I also had report issues with 3.11.

The budget report issue exists in pre-existing, imported reports, and in a report I created from scratch in 4.0.

I have a monthly budget, and it is now June, and the report only showed data up until February. I'm not sure that the data was correct.

Maybe an issue with date formats? I'm in Australia.

Sorry I can' submit a screenshot, I backtracked out of 4.0 as quickly as I could.
Comment 1 Christopher Lam 2020-06-30 01:00:10 EDT
Would be nice for a screenshot to identify the source of the problem.
Comment 2 Peter Kane 2020-06-30 01:45:49 EDT
Created attachment 373753 [details]
V4.0 budget graph

gnucash 3.10 has all months populated

mac 10.15.5
gnucash Version: 4.0
Build ID: 4.0+(2020-06-27)
Finance::Quote: -
Comment 3 Peter Kane 2020-06-30 01:46:48 EDT
Created attachment 373754 [details]
V3.10 budget graph, same data.

V3.10 budget graph, same data.
Comment 4 Christopher Lam 2020-06-30 05:10:58 EDT
Is the regular budget report working properly?

The budget charts had less beta testing.
Comment 5 Christopher Lam 2020-06-30 05:11:27 EDT
Correction:

There were no volunteer beta testers for budget reports.
Comment 6 Peter Kane 2020-06-30 06:51:23 EDT
Created attachment 373756 [details]
Budget report

Shows data in all months
Comment 7 Peter Kane 2020-06-30 06:53:11 EDT
I just posted a data report. 
I had to create a new one to send to you because the report I had created and was using was trashed recently. I say this because it hasn't got exactly the same data as the graph.
Comment 8 Christopher Lam 2020-06-30 06:59:20 EDT
Ok the budget chart was not upgraded together with other charts. This is an omission. I'll create a budget-barchart.scm soon and you can try replace the one inside Gnucash.app
Comment 9 Peter Kane 2020-06-30 07:05:46 EDT
I'm not sure what you mean by replacing budget-barchart.scm, but if you give me instructions I'll try.
I had troubles with another barchart - see separate bug report.

Also some of the other graphs had different functionality. eg. zero crossing on the horizontal axis, whereas previously they were not. I liked the non-zero crossing functionality, so maybe it's not a bug, but it would be a nice option on any graphs in the reporting suite. I didn't report this because I only quickly scanned 4.0 functionality.

As far as I could see the actual reports were working, but as I said previously, I backed out of 4.0 because it's my production system and data (ie my only system).

I produced the reports above using my production data file, and the 4.0 executable. I could go back to 3.10 and it didn't seem to affect my data.

If I were to do other testing I'd have to create a separate test data file, and use the 4.0 executable, but I'm not sure how to separate the reports in this environment, except to use different named instances of the reports for testing.
Comment 10 Christopher Lam 2020-06-30 08:15:14 EDT
Created attachment 373757 [details]
budget-barchart.scm

try this budget-barchart.scm
Comment 11 Christopher Lam 2020-06-30 08:30:41 EDT
Created attachment 373758 [details]
erm use this one instead
Comment 12 Christopher Lam 2020-06-30 09:41:02 EDT
The root cause is that most charts were upgraded from old jqplot to modern chartJS. But budget-barchart was left behind. The attachment in comment 11 is a candidate upgrade. If this works well, it'll replace the mainline report. Note the change from date to period selection. Feedback will be appreciated.
Comment 13 Christopher Lam 2020-07-01 20:27:06 EDT
Fixed for the next release. Needs more testing ideally before 4.1.
Comment 14 Christopher Lam 2020-07-01 22:11:53 EDT
If you are able to find budget-barchart.scm in the Gnucash.app, you can replace it with the current iteration as follows. More testing will be very welcome.

https://raw.githubusercontent.com/Gnucash/gnucash/master/gnucash/report/reports/standard/budget-barchart.scm
Comment 15 Christopher Lam 2020-07-05 00:13:46 EDT
fixed for 4.1.

if you can test more thoroughly by coping budget-barchart.scm into your setup, it would be very appreciated.
Comment 16 Peter Kane 2020-07-05 00:52:44 EDT
thanks. I don't know where to copy budget-barchart.scm into.
Where is the folder in mac OS?
Comment 17 Christopher Lam 2020-07-05 00:55:18 EDT
I dont use MacOS.

Somewhere described in bug 797835#c6

Note You need to log in before you can comment on or make changes to this bug.