GnuCash
Contact   Instructions
Bug 797787 - Feature request: preference setting to open new tabs adjacent to currently active tab (as opposed to at the end of the tab list)
Summary: Feature request: preference setting to open new tabs adjacent to currently ac...
Status: RESOLVED FIXED
Alias: None
Product: GnuCash
Classification: Unclassified
Component: User Interface General (show other bugs)
Version: git-master
Hardware: PC Windows
: Normal enhancement
Target Milestone: ---
Assignee: ui
QA Contact: ui
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-06-07 17:25 EDT by CDB-Man
Modified: 2021-05-16 23:19 EDT (History)
12 users (show)

See Also:


Attachments

Description CDB-Man 2020-06-07 17:25:22 EDT
I maintain a lot of tabs permanently open.  50+ tabs contain custom reports that I permanently want access to.  As such, opening (and rearranging) tabs is quite a task.  Currently, the default behaviour is that all tabs open at the end of the list, i.e. at the far right.  This is fine when you have 10 or less tabs, but a problem when you have 50+ tabs.  In general, I prefer that whenever a new report/tab is opened, it's placed to the right of the currently active tab, so it is "pre-sorted" to where I want it to be.

I realize that not everyone wants this behaviour, so this should be a preference flag in Preferences>Windows

====
[2020.06.07 16:46:20] <CDB-Man> 2. hmm, is there a setting somewher to make it that new reports open to the right of the currently selected tab, rather than at the far right as the last tab?
[2020.06.07 16:46:35] <CDB-Man> i find myself always moving tabs over. i have opver 0+ custom reports always open
[2020.06.07 16:46:40] <CDB-Man> over 30+*
[2020.06.07 16:49:46] <jralls> Have you considered putting the tabs down the side?
[2020.06.07 16:50:40] <jralls> Preferences>Windows
[2020.06.07 16:50:43] <CDB-Man> yes, but that still doesnt help when i have 30+ tabs
[2020.06.07 16:51:10] <CDB-Man> if it was scrollable with the scroll wheel it would be slightly more useful, but that's not the case
[2020.06.07 16:51:17] <CDB-Man> currently i always right click to navigate by context menu
[2020.06.07 16:51:46] <CDB-Man> the option to have new reports open next to the currently active tab woul dbe nice (rathe than always open as the last tab)
[2020.06.07 16:51:55] <CDB-Man> can submit a feature request if it's a feasible change
[2020.06.07 16:52:20] <CDB-Man> hmm, I actually have closer to 50+ tabs open on a permanent basis...
[2020.06.07 16:53:20] <jralls> Good grief.
[2020.06.07 16:54:02] <jralls> It's certainly feasible, though it would need a preference setting for users who want it on the end.
[2020.06.07 16:54:17] <CDB-Man> I run a lot of analytics!  and yes, would be a preference setting for sure
Comment 1 Frank H. Ellenberger 2020-06-07 23:40:57 EDT
1. Instead of "to the right of the currently active tab" I would say "behind the currently active tab in the default writing direction (LTR/RTL)"

2. I believe most users would prefer it. you could ask on the mailing list, if a preference is really required.
Comment 2 CDB-Man 2020-06-07 23:58:09 EDT
I would use "after" rather than "behind", but yes agree with the LTR/RTL comments.  I only bring up the preference question on jrall's suggestion; personally I agree with you a preference is likely not needed.
Comment 3 Bob 2020-06-10 11:06:18 EDT
I poked at this and it is not hard to do, change about 3 lines in gnc_main_window.c, just thinking of LTR at the moment.

Would need to check if OK for 4.0 but this change would create all pages to the right of current page so new register pages would be created right of CoA where ever that may be right ?

Jumps from registers would open new register pages to the right of current one if not already open ?

New Reports would be open to the right of current page ?
Comment 4 CDB-Man 2020-06-10 11:57:16 EDT
> so new register pages would be created right of CoA where ever that may be 
> right?
Don't know what "CoA" means, but if it means currently active tab, then yeah, I would want new registers to open to the right of the currently active one.

> Jumps from registers would open new register pages to the right of current 
> one if not already open?
Yes please.

> New Reports would be open to the right of current page ?
Yep.
Comment 5 Bob 2020-06-10 12:58:05 EDT
Chart of Accounts
Comment 6 CDB-Man 2020-06-10 13:06:43 EDT
I would not treat the chart of accounts any differently.  Just keep it as "to the right of the currently active tab".  So yes, if you open an account from the chart, it would be right of the chart, given that the chart is active.
Comment 7 Christopher Lam 2020-06-14 08:03:36 EDT
As a corollary I wish the Window menu populated itself with all tabs. RClick the tab bar gets weary quickly.
Comment 8 Bob 2020-06-14 08:04:26 EDT
Created PR 737 for this change as unsure if OK for 4.0
Comment 9 Bob 2020-06-14 08:05:58 EDT
Chris I am not sure what you mean by that?
Comment 10 Christopher Lam 2020-06-14 08:09:18 EDT
(In reply to Christopher Lam from comment #7)
> As a corollary I wish the Window menu populated itself with all tabs. RClick
> the tab bar gets weary quickly.

(In reply to Bob from comment #9)
> Chris I am not sure what you mean by that?

If you have many register/report tabs open, the only way to navigate to an arbitrary tab is to LClick the relevant tab, or RClick the tab-bar. The tabs do not populate the Window menu. I can try Ctrl-PgUp/PgDn to switch but is not reliable. So, to navigate tabs is awkward.
Comment 11 Bob 2020-06-14 08:30:07 EDT
(In reply to Christopher Lam from comment #10)
 
> If you have many register/report tabs open, the only way to navigate to an
> arbitrary tab is to LClick the relevant tab, or RClick the tab-bar. The tabs
> do not populate the Window menu. I can try Ctrl-PgUp/PgDn to switch but is
> not reliable. So, to navigate tabs is awkward.

I have seen previous bugs reported for tab navigation, some pages use that key combo and so it is eaten, maybe I will take a closer look at what they are saying.

Have you tried Ctrl-Alt-PgUp/PgDn, that works for me.

Using the Windows toolbar would still equate to the same number of mouse clicks to RClick tab, then select or would you do this from the keyboard.
Comment 12 Christopher Lam 2020-06-14 08:53:01 EDT
(In reply to Bob from comment #11
> I have seen previous bugs reported for tab navigation, some pages use that
> key combo and so it is eaten, maybe I will take a closer look at what they
> are saying.
> 
> Have you tried Ctrl-Alt-PgUp/PgDn, that works for me.

I'm not sure 100% reliable though.

> Using the Windows toolbar would still equate to the same number of mouse
> clicks to RClick tab, then select or would you do this from the keyboard.

You're right I'm a heavy keyboard user, using all sorts of gtk accelerator keys. Alt-W, hold Up/Down, Enter would be better to select a tab :)
Comment 13 Bob 2020-06-14 09:15:43 EDT
I wonder if there is a short cut for the right tab menu, if not maybe it can be added?
Comment 14 Christopher Lam 2020-06-14 11:19:17 EDT
(In reply to Bob from comment #11)
> Have you tried Ctrl-Alt-PgUp/PgDn, that works for me.

Specifically this does not work when you click on the WebKit canvas. [Ctrl][Alt]PgUp/PgDn goes to Webkit to scroll report.
Comment 15 CDB-Man 2020-06-14 16:25:31 EDT
I agree with Bob, having the tabs in the Window menu vs the right click context menu isn't significantly different.  Something slightly more useful would be a tab search feature (perhaps in the Window , as in open a text box, start typing the name of the open tab, and the list shortens with the search.  But I digress, this would be quite the significant enhancement.
Comment 16 CDB-Man 2020-06-14 16:26:41 EDT
Even at 50 open tabs, I don't mind the right click menu... for now... but yes, a solution would be great.  Navigating is still less cumbersome than opening a new tab at the end of the 50, then trying to drag it back to the start of the list!
Comment 17 Bob 2020-07-22 07:49:07 EDT
Just pushed the change to mint so that new plugin pages are added next to the current page. Will be in 4.1

Other changes will be addressed in existing bugs.
Comment 18 Richard Ullger 2020-07-31 13:55:10 EDT
Where is the preference to turn this off?
Comment 19 Alun Champion 2020-08-09 18:50:29 EDT
Please make this a preference setting. This is really not the preferred behaviour for some.
Comment 20 CDB-Man 2020-08-15 20:53:21 EDT
Well, given that my original feature request was for a preference setting rather than an immutable option, I'll re-open the ticket to reflect this.  It should be a preference setting in Preferences > Window
Comment 21 Geert Janssens 2020-08-18 08:57:27 EDT
It looks like about every visual change that is made will trip up at least one user because they were used to how it was.

Before anyone starts implementing this option, I'll point out that just adding an option to keep old behaviour is not good design.

Also saying "this is not the preferred behaviour" is not sufficient. It doesn't motivate what was better about the old behaviour. We need strong motivations from a design point of view.

The design motivation to open a tab next to the existing one is that if you open a tab it's very likely you want to use it soon afterwards. So it makes sense to put it close to where you currently are, namely close to the current tab.

What design concept warrants opening tabs at the very end ? Firefox doesn't do it.

For reference I have looked at Firefox and Chromium, two webbrowsers and also heavy users of a tab interface. They also will position new tabs right next to the current tab (with the subtle improvement that if you open several one after another they will all appear next to the existing tab but in order they were opened - that is the first opened will be closest, the last opened will be furthest). I haven't found any preference setting to change this. So it seems browser designers agree on the concept of opening new tabs close to the existing one.
Comment 22 Alun Champion 2020-08-18 10:28:27 EDT
If you are using browsers as a comparison then multiple browsers offer 'pin' tab (e.g. Chrome, Safari), any new tab opens after all of the pinned tabs. This would be acceptable behaviour but there is no pinned tab behaviour in Gnucash.

My tabs are on the left and I have a number of reports 'pinned'. This change breaks my usage, so would prefer it be an option or pinned tabs.
Comment 23 Richard Ullger 2020-08-18 10:46:42 EDT
(In reply to Geert Janssens from comment #21)

In Firefox, new tabs opened with the + button or ctrl-T open at the end of the tab list. Tabs opened from a link in an existing tab open to the right of that tab. Firefox has settings for these.

browser.tabs.insertAfterCurrent (default value false)
browser.tabs.insertRelatedAfterCurrent (default value true)

In this respect I would consider registers opened using the jump-to button and hyperlinks in a report to be related tabs.
Comment 24 Geert Janssens 2020-08-18 10:55:24 EDT
Now we're getting somewhere. Thanks for the added details.

I think "pinned tabs" is a good enhancement on its own.

And in addition, the concept of related tabs is strong as well. I agree that tabs opened from a menu have much less relation to the current tab than the jump-to or hyperlinks are from. So that's a good metric to decide new tab location on.

As for the options in firefox, I suspected it to be very likely their advanced options could allow such configuration. And unfortunately that's also where I choose not to follow firefox. We don't have enough manpower to manage that extreme configuration flexibility.

So if we can come to a better overal experience by refining the tab location based on relatedness I'm ok with that.
Comment 25 David 2020-11-23 14:15:42 EST
Is there a plan to revert this patch while a better solution is found? Leaving this in place inconveniences a far larger number of users than it benefits.
Comment 26 JohnL 2021-04-06 21:06:53 EDT
I agree that the "fix" as implemented is inconvenient for my workflow since I usually search from the Account List. While I don't particularly care what the ultimate implementation is, my hope would be that options of placing the tab either at the beginning or the end of the tabs list be included in the next change that addresses this issue.
Comment 27 David 2021-04-07 21:37:05 EDT
I repeat my request that this patch be reverted at the soonest opportunity. I (and others) continue to suffer with the ramifications of its change, and continue to think that interface changes such as this should not be made based on the needs of a single user.
Comment 28 Frank H. Ellenberger 2021-04-08 00:53:43 EDT
(In reply to David from comment #27)
> … interface changes such as this should not be made
> based on the needs of a single user.

It's more than one, but I understand that one man's Uhl is another's nightingale. ;-)
Comment 29 Frank H. Ellenberger 2021-04-08 01:01:15 EDT
IIRC we can also create a poll on uservoice.
Comment 30 David 2021-04-08 08:14:18 EDT
Frank, I see ONE user (cdb-man) requesting this change. Chris makes a different ("corollary") request in comment 7. No one else joined the conversation to support the request; we only have Bob noting the ease of the change. 

In contrast, we have four different users (me, Richard, Alun, and now John) expressing displeasure at this change. (I will note, too, that cdb-man suggested that his idea would be better implemented as a user-configured preference, which has been dismissed by Geert) 

As any researcher will know, this does not necessarily reflect the true sentiment of the broader community (certainly not on a sample size of 5), although an 80-20% split is pretty extreme and can at least indicate a potential trend. I am not sure that a uservoice poll would be any more reliable, and in the meantime, those of us who have expressed our displeasure at this change continue to suffer. Just because a change is easy doesn't mean that it's right.
Comment 31 JohnL 2021-05-07 14:48:10 EDT
Problem Solved??? at least for me. I simply dropped back to version 4.0 while waiting to see what happens. I know I'll miss out on any other updates since then but I can live with that. My other option is to download the source and revert the code for this change as each update comes out. Not sure it's worth it to me to do that every time so I may be on 4.0 for the foreseeable future.
Comment 32 David 2021-05-07 15:56:53 EDT
JohnL: no. It isn't solved. And every day I use gnucash, I get the reminder of how it isn't solved. I'm glad you've got a way to work around this, but I'm not planning to back load 4.0, and I won't be compiling and maintaining my own fork of the project. Based on the responses here, I'd suspect this is another one of those changes to the program that will simply live on because it Has Been Made.
Comment 33 Christopher Lam 2021-05-16 20:13:53 EDT
This will be fixed in maint for 4.6. New boolean global preference in "Windows" tab: "Opens new tab adjacent to current tab instead of at the end".
Comment 34 David 2021-05-16 23:19:14 EDT
Oh, thank you! I can hardly wait!

Note You need to log in before you can comment on or make changes to this bug.