GnuCash
Contact   Instructions
Bug 797760 - Broken register split activity -- cannot delete splits, unable to tab complete account name
Summary: Broken register split activity -- cannot delete splits, unable to tab complet...
Status: RESOLVED FIXED
Alias: None
Product: GnuCash
Classification: Unclassified
Component: Register (show other bugs)
Version: 3.902
Hardware: PC Windows
: Normal normal
Target Milestone: ---
Assignee: ui
QA Contact: ui
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-05-17 00:47 EDT by CDB-Man
Modified: 2020-05-23 16:51 EDT (History)
9 users (show)

See Also:


Attachments

Description CDB-Man 2020-05-17 00:47:30 EDT
This was tested on Version: 3.902
Build ID: git 3.902-126-g5b597dfea+(2020-05-16)

1. I am unable to delete any contents in a split using DEL or backspace.  Confirmed that this applies to at least: split memo/description, split account name, split debit/credit amounts.  The only way to delete a split is right-click delete split.
2. TAB auto complete on account name no longer works.  Normally, if you partially enter the account name, after the suggestion appears in the dropdown, you can TAB to auto complete the highlighted suggestion.  Instead TAB will trigger a prompt asking if you want to create a new account, using the partially filled name.

[2020.05.17 00:28:25] <CDB-Man_> hmmm, with the new nightly build
[2020.05.17 00:28:34] <CDB-Man_> i can't delete accounts from a split in my transaction...
[2020.05.17 00:28:45] <CDB-Man_> like I select the account and try to backspace, and nothing happens....
[2020.05.17 00:29:42] <CDB-Man_> I have to right click and delete split
[2020.05.17 00:29:45] <CDB-Man_> did something change?
[2020.05.17 00:30:49] <fell> I never knew about deleting a split by backspace.
[2020.05.17 00:31:06] <fell> Is it somewhere documented?
[2020.05.17 00:31:24] <CDB-Man_> well fell, what i've done for the longest time is this
[2020.05.17 00:32:08] <CDB-Man_> 1. select the sploit description and delete it with backspaces
[2020.05.17 00:32:08] <CDB-Man_> 2. tab over to the split account and delete it with backspaces
[2020.05.17 00:32:08] <CDB-Man_> 3. tab over to the debit/credit amount and delete it with backspaces
[2020.05.17 00:32:08] <CDB-Man_> 4. tab to the next row, and the split is now gone
[2020.05.17 00:32:17] <CDB-Man_> step #2 no longer works
[2020.05.17 00:33:09] <fell> Ah, I use [DEL] there.
[2020.05.17 00:33:22] <CDB-Man_> [DEL] also not working
[2020.05.17 00:33:43] <CDB-Man_> also, in the account column, I used to be able to type the first few letters of the account name, and when the suggestion appears in the dropdown, hit tab to auto complete.  now that is broken
[2020.05.17 00:33:57] <CDB-Man_> it's asking to create a new account of the partialy typed in text... instead of auto completing
[2020.05.17 00:34:12] <CDB-Man_> something definitely changed
[2020.05.17 00:34:43] <CDB-Man_> need to revert back to gnucash 3.10 stable..... this is quite annoying
[2020.05.17 00:35:06] <CDB-Man_> This was tested on Version: 3.902
[2020.05.17 00:35:06] <CDB-Man_> Build ID: git 3.902-126-g5b597dfea+(2020-05-16)
[2020.05.17 00:35:12] <CDB-Man_> shall I file a bug report?
[2020.05.17 00:38:08] <fell> No Problem with Build ID: git 3.10-72-g659f785cb+(2020-05-15)
[2020.05.17 00:38:26] <CDB-Man_> hmm, i cant even DEL the numbers wither (step 3)
[2020.05.17 00:38:36] <CDB-Man_> that's the one on Maint?
[2020.05.17 00:38:59] <fell> yes, so you could bisect master.
[2020.05.17 00:39:00] <chris> CDB-Man: go ahead. jean_laroche did some work there.
[2020.05.17 00:39:23] <CDB-Man_> (Btw, what is the difference between Maint and Master anyways? I usually download maint, only downloaded master since chris pointed there for the report bug)
[2020.05.17 00:39:56] <chris> maint=upcoming 3.11, master=upcoming 4.x with backward-incompatible changes.
[2020.05.17 00:39:57] <fell> Maint will become 3.11, master 4.0
[2020.05.17 00:40:20] <CDB-Man_> Ooh, exciting
[2020.05.17 00:40:43] <chris> you've uncovered a valid bug...<BS> doesnt work as expected
[2020.05.17 00:41:10] <chris> maint will be for final 3.x release, and no new features allowed there
[2020.05.17 00:41:35] <CDB-Man_> Chris, what do you mean by the balaance sheet not working?
[2020.05.17 00:41:48] <CDB-Man_> I'm looking at register here, or am I missing a step in your thought process
[2020.05.17 00:42:52] <chris> <BS>=backspace
[2020.05.17 00:43:29] <CDB-Man_> ah. well DEL also does not work either
[2020.05.17 00:44:01] <CDB-Man_> tab auto-complete on account name also does not work (can you replaciate?)
Comment 1 Christopher Lam 2020-05-17 00:52:19 EDT
broken:

[ENTER]
[CTRL-A], [DEL]
[CTRL-A], [BS]
[TAB]
[BS] repeatedly
[HOME] then [DEL]

etc.

Unfortunately this makes it quite difficult to use and will attract a lot of complaints.
Comment 2 Chris Good 2020-05-17 03:37:41 EDT
This looks like a duplicate of Bug 797052 to me. John Ralls has been working on fixing this in master.
Comment 3 John Ralls 2020-05-17 10:55:13 EDT
Chris Good, it's not a duplicate of that bug, though it does repeat and expand upon the complaints you raised in your latest comment to that bug.
Comment 4 Robert Chapin 2020-05-17 15:18:04 EDT
The Shift+Left key combination is broken.  Selection never exceeds one char in size.

The Shift+Right key combination is broken.  After selecting one char, repeating the input does nothing at all.
Comment 5 John Ralls 2020-05-17 15:32:26 EDT
I can't replicate the backspace and delete not working at all. What I can replicate is that they don't delete the selection. Note that backspace removes the character to the left of the cursor and delete removes the one to the right (except in RTL languages like Hebrew, but we're all LTR users here so far. Behavior is also different when an input method is in use but that's not the case for European languages so presumably not in play here.) What I can replicate is that the selection is ignored when deleting, so if you have the whole field selected with the cursor at the right end of the text and press delete all that happens is that the text selection is unselected. If you press backspace the text selection is unselected and the right-most character (the one to the left of the cursor) is removed. Note that you can type a character and the selection will be removed and the new character entered.

I have a fix written for that that works on MacOS. I'm doing a test-build on Windows now to check that it works there as well.

The account selector's behavior has changed a bit thanks to an added feature: When you are starting from a blank account cell and type the leading letters of the accounts you want in order and separated with the account separator you get the auto-fill behavior your used to and can tab to the debit column and the account you wanted will be filled in as before. The new feature is that you can also type any part of a fully qualified account name and the list will shrink to contain only the accounts whose fully qualified names include the string. When that happens the entry--the part you type in--doesn't autofill. When you've gotten the list of accounts small enough you can use the up and down arrows to select one or you can use Enter to confirm the already selected one, then press Tab to move on to the next field.
Comment 6 John Ralls 2020-05-17 19:53:46 EDT
I've pushed some commits that fix the selection problems, try tomorrow's nightlies.

I think I can improve the account selector a bit as well, but that still needs some tweaking and I'm out of time for tonight.
Comment 7 John Ralls 2020-05-18 17:18:35 EDT
Today's fixes (for tomorrow's nightly) restores the expected account field behavior for quickfill mode and ensures that quickfill mode is in effect on entry.

The selection behavior is distinct in that field. Note that there are two parts, the entry and the popup (or down, depending on which way there's more room). The entry is the part that you type in. When you're in quickfill mode the entry will show the inferred part selected and the popup will show all of the accounts. When you're in type-ahead mode the entry will show only what you've typed and the popup will show only the accounts that match.

In quickfill mode tabbing out will accept what's displayed and in typeahead mode it will display what's selected in the popup. 

I think that resolves all of the issues here, please test tomorrow's nightly build.
Comment 8 Mike Alexander 2020-05-18 18:38:53 EDT
These changes fix most of the problems, thanks.  The one thing I noticed right away is more of an annoyance than a serious problem.  The pop-up list of matched accounts in quick fill mode is always maximum height even if the list only contains one account.  This is a particular nuisance if you're using screen magnification since the relevant part of the list is a long way from the input area. which involves a lot of mousing around to see it all.  This may or may not be a new problem.
Comment 9 CDB-Man 2020-05-18 19:51:08 EDT
Didn't test in detail, but it looks like the issues are mostly fixed:
1. Now able to delete the selected text in all fields (description/memo, account selector, debit/credit)
2. Tab auto complete of the currently highlighted dropdown works

[2020.05.18 17:35:07] <CDB-Man_> jralls: for #760 I see you mention that your fixes address the account selector, what about the other fields? Debit, credit, description, where we were unable to delete the selected text
[2020.05.18 17:36:16] <jralls> CDB-Man, those were yesterday's fixes, mentioned in https://bugs.gnucash.org/show_bug.cgi?id=797760#c6.
[2020.05.18 17:36:32] <jralls> So you can try that out today.
[2020.05.18 17:37:26] <CDB-Man_> Ah, missed that. Will give it a whirl this evening
=====
[2020.05.18 18:20:24] <CDB-Man> gnucash-3.902-2020-05-18-git-3.902-132-g3e44af3c7+.setup.exe -- downloading this now
[2020.05.18 19:41:01] <CDB-Man> Yep, the issues seem mostly fixed
[2020.05.18 19:41:16] <CDB-Man> didn't test in detail, but the memo/description, account selector, and debit/credit fields work again
Comment 10 John Ralls 2020-05-20 20:03:39 EDT
I've fixed the resize problem, no more blank space or the one choice being way up at the top of the register.

CDB-Man, close when you think you've tested enough reply if you find any more problems.
Comment 11 Robert Chapin 2020-05-21 07:05:37 EDT
Seems fixed!

THANK YOU
Comment 12 CDB-Man 2020-05-23 16:51:51 EDT
Looks like all the issues in this particular report are now resolved (or at the very least, no longer apparent).

Confirmed with Master build:
> gnucash-3.902-2020-05-23-git-3.902-157-gd8aecf969+.setup.exe

Note You need to log in before you can comment on or make changes to this bug.