The current matching code ignores the fact that transactions in the register may have been previously matched with imported transactions, in which case they should not be available as matches for new imported transactions. To see that, create an ofx with 1 transaction of $20 on a certain day. Import it, add it to the register. Now edit the ofx file to change the transaction ID, leaving the date and amount identical. Import the ofx: GC will match it to the $20 transaction you previously matched.
A PR was created for this. https://github.com/Gnucash/gnucash/pulls/@me
Your PR #717 was added to maint and will be in the next release 3.11
Bob thinking of either reverting this -- see bug 798128 or the import-matcher can be made more clever see https://github.com/Gnucash/gnucash/pull/717
I think it's unreasonable to break matching to accommodate a bank which exports OFX with inconsistent FITIDs. The OFX spec dictates the FITID must be unique and invariant.
(In reply to Christopher Lam from comment #4) > I think it's unreasonable to break matching to accommodate a bank which > exports OFX with inconsistent FITIDs. The OFX spec dictates the FITID must > be unique and invariant. That was not the motivation for the PR.
(In reply to Jean Laroche from comment #5) > (In reply to Christopher Lam from comment #4) > > I think it's unreasonable to break matching to accommodate a bank which > > exports OFX with inconsistent FITIDs. The OFX spec dictates the FITID must > > be unique and invariant. > > That was not the motivation for the PR. Ok I misunderstood -- looking forward for amendment.
