Following work https://github.com/Gnucash/gnucash/pull/592 completed, the current behaviour in git-maint: * budget viewer is sensitive to sign-reversal policy * budget viewer is also sensitive to sign-reversal policy. To illustrate, open the budget editor, then open the global Preferences window, and modify the Sign Reversal Policy. EXPECTED: * all numbers in the budget editor/viewer follow the new sign policy immediately OBTAINED: * only the spreadsheet numbers follow the sign policy, e.g. Income and Equity budget amounts flip from positive to negative or vice-versa. * budget totals are not immediately redrawn * clicking OK to the Preferences window to signify acceptance will actually redraw the budget totals to reflect sign policy.
Chris, I must be blind, what exact preference option?
Created attachment 373472 [details] A book with feature unreversed-budgets enabled Bob, not blind - I forgot to clarify and attached a featured book.
global preference is Accounts > Reversed Balance Accounts
OK, opened your file and the top 4 collapsed rows change sign and colour when I change the above preference option including the column with Title 'Total'. All the bottom totals have 0.0
OK, Changed all the accounts from USD to GBP and now the bottom totals change but only when I exit the preference window so I guess that is the problem.
Yep, that's exactly the problem. Chris and I ran into this while testing his budget improvement work. The bottom totals should get an update trigger if the preference changes, just like the budget details do. My first guess would be this needs some digging into the account_tree widget to check where it listens for such changes and implement something similar for the budget view widget.
Turns out they have been updated, just wipe your mouse over the columns in the totals tree view. I can fix this by registering three pref call backs which do a gtk_widget_queue_draw on the totals tree view. Will think some more but may be the only way.
I can do this differently by connecting to the row-changed signal of the account tree model and then doing a redraw on the bottom tree view, this will also fix when you change the preference for using negative amounts in red.
Yep, sounds like a good plan. The bottom tree view is a slave of the account tree model anyway. All changes to the account tree model affect the bottom tree view in some way.
I have pushed my fix to maint and hopefully works for you. Close if OK or report back if still not working.
As usual, thank you for the fix!
