GnuCash
Contact   Instructions
Bug 797415 - cannot build without libsecret-1-dev
Summary: cannot build without libsecret-1-dev
Status: RESOLVED FIXED
Alias: None
Product: GnuCash
Classification: Unclassified
Component: Build system (show other bugs)
Version: git-master
Hardware: PC Windows
: Normal normal
Target Milestone: ---
Assignee: core
QA Contact: core
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-09-14 05:28 EDT by Christopher Lam
Modified: 2019-09-17 11:24 EDT (History)
6 users (show)

See Also:


Attachments
cmake stdout (5.22 KB, text/plain)
2019-09-14 05:28 EDT, Christopher Lam
no flags Details
cmake stdout after installing libsecret-1-dev (5.22 KB, text/plain)
2019-09-14 05:29 EDT, Christopher Lam
no flags Details
CMakeOutput (40.83 KB, text/x-log)
2019-09-17 09:32 EDT, Christopher Lam
no flags Details
CMakeError (3.92 KB, text/x-log)
2019-09-17 09:33 EDT, Christopher Lam
no flags Details

Description Christopher Lam 2019-09-14 05:28:46 EDT
Created attachment 373394 [details]
cmake stdout

Here's output without libsecret-1-dev

cmake stdout output attached, stderr output pasted:

CMake Error at gnucash/CMakeLists.txt:40 (add_executable):
  Target "gnucash" links to target "PkgConfig::LIBSECRET" but the target was
  not found.  Perhaps a find_package() call is missing for an IMPORTED
  target, or an ALIAS target is missing?


CMake Error at gnucash/gnome/CMakeLists.txt:138 (add_library):
  Target "gnc-gnome" links to target "PkgConfig::LIBSECRET" but the target
  was not found.  Perhaps a find_package() call is missing for an IMPORTED
  target, or an ALIAS target is missing?


CMake Error at gnucash/gnome-utils/CMakeLists.txt:197 (add_library):
  Target "gncmod-gnome-utils" links to target "PkgConfig::LIBSECRET" but the
  target was not found.  Perhaps a find_package() call is missing for an
  IMPORTED target, or an ALIAS target is missing?


CMake Error at gnucash/gnome-search/CMakeLists.txt:43 (add_library):
  Target "gncmod-gnome-search" links to target "PkgConfig::LIBSECRET" but the
  target was not found.  Perhaps a find_package() call is missing for an
  IMPORTED target, or an ALIAS target is missing?


CMake Error at gnucash/html/CMakeLists.txt:37 (add_library):
  Target "gncmod-html" links to target "PkgConfig::LIBSECRET" but the target
  was not found.  Perhaps a find_package() call is missing for an IMPORTED
  target, or an ALIAS target is missing?
Comment 1 Christopher Lam 2019-09-14 05:29:46 EDT
Created attachment 373395 [details]
cmake stdout after installing libsecret-1-dev

after installing libsecret-1-dev
Comment 2 Geert Janssens 2019-09-14 10:38:18 EDT
@jralls: could this be a use case for cmake's generator expressions ?
Comment 3 Geert Janssens 2019-09-14 11:40:49 EDT
Something like this: replace PkgConfig::LIBSECRET the add_xyz rules with 
$<$<BOOL:PkgConfig::LIBSECRET>,PkgConfig::LIBSECRET>

Untested though, I'm not in a position to code right now...
Comment 4 John Ralls 2019-09-14 19:19:50 EDT
Good thought. The incantation is actually
  $<$<BOOL:${LIBSECRET_FOUND}>:PkgConfig::LIBSECRET>
which I will proceed to use for GtkMacIntegration as well.
Comment 5 Christopher Lam 2019-09-15 07:55:38 EDT
confirm it's now building absolutely fine!
Comment 6 Geert Janssens 2019-09-17 04:42:54 EDT
Chris, I presume you verified this after removing libsecret-1-dev again ?
Comment 7 Christopher Lam 2019-09-17 09:31:32 EDT
Geert: oops you're right it's still borking. But less whining; no "CMake Error at gnucash/CMakeLists.txt:40" errors.

-- The C compiler identification is GNU 8.3.0
-- The CXX compiler identification is GNU 8.3.0
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /usr/bin/c++
-- Check for working CXX compiler: /usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Found UnixCommands: /usr/bin/bash  
-- Found Git: /usr/bin/git (found version "2.20.1") 
-- Looking for pthread.h
-- Looking for pthread.h - found
-- Looking for pthread_create
-- Looking for pthread_create - not found
-- Looking for pthread_create in pthreads
-- Looking for pthread_create in pthreads - not found
-- Looking for pthread_create in pthread
-- Looking for pthread_create in pthread - found
-- Found Threads: TRUE  
-- Found PkgConfig: /usr/bin/pkg-config (found version "0.29.1") 
-- Checking for module 'glib-2.0>=2.40'
--   Found glib-2.0, version 2.60.4
-- Checking for module 'gio-2.0'
--   Found gio-2.0, version 2.60.4
-- Checking for module 'gobject-2.0>=2.20'
--   Found gobject-2.0, version 2.60.4
-- Checking for module 'gmodule-2.0>=2.20'
--   Found gmodule-2.0, version 2.60.4
-- Checking for module 'gthread-2.0>=2.20'
--   Found gthread-2.0, version 2.60.4
-- Checking for module 'libxml-2.0>=2.7.0'
--   Found libxml-2.0, version 2.9.4
-- Checking for module 'libxslt'
--   Found libxslt, version 1.1.32
-- Checking for module 'webkit2gtk-4.0'
--   Found webkit2gtk-4.0, version 2.24.4
-- Checking for module 'gtk+-3.0>=3.18.0'
--   Found gtk+-3.0, version 3.24.8
-- Checking for module 'zlib'
--   Found zlib, version 1.2.11
-- Found Gettext: /usr/bin/msgmerge (found suitable version "0.19.8.1", minimum required is "0.19.6") 
-- Found SWIG: /usr/bin/swig3.0 (found suitable version "3.0.12", minimum required is "2.0.10") 
-- Using guile-2.0.x
-- Using guile SRFI-64
-- Using guile textual-ports
-- Checking for module 'gwenhywfar>=4.9.99'
--   Found gwenhywfar, version 4.20.0
-- Checking for module 'aqbanking>=5.3.4'
--   Found aqbanking, version 5.7.8
-- Looking for AB_Banking_RuntimeConfig_SetCharValue
-- Looking for AB_Banking_RuntimeConfig_SetCharValue - not found
-- Checking for module 'gwengui-gtk3'
--   Found gwengui-gtk3, version 4.20.0
-- Checking for module 'libofx'
--   Found libofx, version 0.9.14
-- Performing Test HAVE_OFX_BUG_39
-- Performing Test HAVE_OFX_BUG_39 - Failed
-- Found LibXslt: xslt;xml2 (found version "1.1.32") 
-- Found PythonInterp: /usr/bin/python3 (found suitable version "3.7.3", minimum required is "3") 
-- Found PythonLibs: /usr/lib/x86_64-linux-gnu/libpython3.7m.so (found suitable version "3.7.3", minimum required is "3") 
-- Found Perl: /usr/bin/perl (found version "5.28.1") 
-- Found the following ICU libraries:
--   i18n (required)
--   uc (required)
-- Found ICU: /usr/include (found version "63.1") 
-- Checking for module 'libsecret-1>=0.18'
--   No package 'libsecret-1' found
-- Performing Test have_stringop_truncation
-- Performing Test have_stringop_truncation - Success
-- Checking for GTEST
-- Configuring incomplete, errors occurred!
See also "/home/chris/sources/code/build/CMakeFiles/CMakeOutput.log".
See also "/home/chris/sources/code/build/CMakeFiles/CMakeError.log".
Comment 8 Christopher Lam 2019-09-17 09:32:45 EDT
Created attachment 373397 [details]
CMakeOutput
Comment 9 Christopher Lam 2019-09-17 09:33:23 EDT
Created attachment 373398 [details]
CMakeError
Comment 10 Geert Janssens 2019-09-17 09:55:20 EDT
That doesn't seem to be related to the absence of libsecret's dev package directly. It may be you have to rerun cmake in a clean build directory as the presence of libsecret is gets cached.

However it doesn't abort on libsecret. configuring in your case ends with the GTEST test. Mine still does GMOCK afterwards and several other checks.
Comment 11 Christopher Lam 2019-09-17 11:24:18 EDT
Oops again. It was the GTEST /home/chris/sources/code/googletest/googletest/ rather than /home/chris/sources/code/googletest/ change that caught me this time. Fixing GTEST did allow build successfully. Sorry for noise!

Note You need to log in before you can comment on or make changes to this bug.