GnuCash
Contact   Instructions
Bug 797348 - Wrong column order for RTL writing in GUI elements
Summary: Wrong column order for RTL writing in GUI elements
Status: NEW
Alias: None
Product: GnuCash
Classification: Unclassified
Component: User Interface General (show other bugs)
Version: 3.6
Hardware: PC Linux
: Normal normal
Target Milestone: ---
Assignee: ui
QA Contact: ui
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-08-14 17:13 EDT by Frank H. Ellenberger
Modified: 2019-09-05 11:08 EDT (History)
6 users (show)

See Also:


Attachments
Amounts are not aligend to the right (52.28 KB, image/png)
2019-09-05 11:08 EDT, Avi Markovitz
no flags Details

Description Frank H. Ellenberger 2019-08-14 17:13:13 EDT
As I was testing he.po I watched the following:
Chart of accounts is OK: First column at the right border.

Register is wrong: First column left. You have to read in many jumps to read a line.

Probably we will find more GUI elements with this behaviour.
Comment 1 John Ralls 2019-08-14 20:46:53 EDT
Maybe not, the register is really old custom code that's never been adapted for RTL.

If you start GnuCash from the command line with the '--extra' option you'll see an "Extensions" menu on the menubar. Select an account on the Accounts page then select Extensions>Register2>Open Account. I think that may display RTL correctly.

Register2 was an attempt to rewrite the register using GtkTreeView as a replacement for the ancient register. We intended it for 2.6 but it wasn't ready in time and still hasn't been completed. I suspect that it may be the only reasonable way to enable RTL in the register.
Comment 2 Bob 2019-08-16 12:00:23 EDT
Out of curiosity how did you test this?
Comment 3 John Ralls 2019-08-16 12:10:27 EDT
Bob,

Just set your locale to Arabic or Hebrew and have a go.
Comment 4 Frank H. Ellenberger 2019-08-16 19:36:00 EDT
Bob, because it has become much harder without the stock buttons, prepare a file with LANG=C, open all views, you want to check, save and then open it with LANG=he_IL.utf8, ar_*, fa_IR.utf8.
ur_PK.utf8 seems not to be properly marked - at least on my system
Comment 5 Frank H. Ellenberger 2019-08-16 19:43:01 EDT
To have all region settings, better prepare the file with i.e.
LANG=he_IL.utf8 LANGUAGE=C
Comment 6 Bob 2019-08-22 09:52:57 EDT
Thanks for the info.
I can not get gtk to recognise the change of local but Gnucash does in my Gentoo VM's but I do have a Fedora30 VM that does so I can use that as when needed.
Comment 7 Frank H. Ellenberger 2019-09-04 21:55:02 EDT
I just saw gnucash/register/ledger-core/split-register-layout.c has hardcoded CELL_ALIGN_RIGHT, CELL_ALIGN_LEFT
Comment 8 Bob 2019-09-05 04:14:44 EDT
If I have time I will have a look at this.
Comment 9 Avi Markovitz 2019-09-05 10:35:53 EDT
Register2 is properly right-aligned (running in Hebrew), actually, it looks pretty cool...
Comment 10 Avi Markovitz 2019-09-05 11:08:31 EDT
Created attachment 373383 [details]
Amounts are not aligend to the right

This probably is not related or even might not belong here, however, it will be nice if numbers(amounts) on the account tab are also aligned to the right.

Note You need to log in before you can comment on or make changes to this bug.