Created attachment 373282 [details] csv file of exchange rates. I have a set of currency conversion data based on HKD to JPY, THB, USD, and AUD. When I import these prices, the "Price Database" shows only three currencies (AUD, HKD, and USD). The THB and JPY data gets included in the HKD data. It seems that these should be based around the "accounting currency" of the books, but gnucash does not seem to incorporate that concept. I have attached the csv file with the exchange rate data that demonstrates the issue. (Import the Price Data then open the "Price Database" window).
I imported your prices into a new file and all looks how I expect it to be. The rates between HKD to USD and AUD in your file are less than 1 and so they get converted to there reciprocal and stored under USD and AUD. I checked also buy creating two accounts, one in HKD and one is USD and then adding a simple transaction between the two and when the transfer dialogue pops up used the fetch rate button. After this, looking in the 'Price Database' I see the fetched price under USD.
This was changed in the last release of GnuCash (3.5). The code to reverse currency exchange rates less than 1 has been removed since it is no longer necessary. You shouldn't see this behavior in that version.
Was your change to do with price retrieval? Does that apply to the transfer dialog also as lines 1622 seem to say otherwise. Just looking for clarification as the price importer I wrote does, see lines 284 of gnc-imp-props-price.cpp
Yes, the change I mentioned affected only price retrieval using the "Get Quotes" button or equivalent. I didn't realize there was code elsewhere to invert prices less than 1. The code in gnc-imp-props-price.cpp and in dialog-transfer.c should be changed too. I don't have time to do that right now, but if no one else does it I'll get to it eventually.
I have changed the importer and the transfer dialogue to remove the inversion for prices less than 1. This will be in version 3.6 so please test when available and report back so this bug can be closed.
No reply for almost 2 years. I'll assume the issue is fixed. Feel free to reopen if you still run into this.
