While I tried to find, why the TAN field is still sometimes passowrd like [https://lists.gnucash.org/pipermail/gnucash-de/2019-April/010590.html] despite https://github.com/Gnucash/gnucash/commit/47c35aeaf9ea60ea2278635a0e79d9e13d0a0329#diff-7d8b963127def26b06716af6e17b35d0 I got a warning, that it was written for gtk 2.16. grep -inr '<requires lib="gtk' gnucash says it is the last gtk2 file.
Bob, are you willing to convert it?
I think I came across this when doing all the other files and left it as I do not use it so could not judge the changes were correct as it also affected the c source files. I will have a look and make some changes but someone else will need to prove them correct.
OK, after it is done I will ask on the german list for testing.
Frank just pushed the changes for conversion to gtk3. All looks OK in the glade viewer and what I can see in Gnucash.
Bob, I sent 2 mails: https://lists.gnucash.org/pipermail/gnucash-de/2019-May/010602.html https://lists.gnucash.org/pipermail/gnucash-devel/2019-May/043837.html Let us see the feedback.
I got a first answer: https://lists.gnucash.org/pipermail/gnucash-de/2019-May/010609.html 1. Requested in Bug 679357 before: The TAN field should not be of type password. Transaction Authentication Numbers are these days only for a very short time valid. It seems https://github.com/Gnucash/gnucash/blob/maint/gnucash/import-export/aqb/gnc-gwen-gui.c#L1019--L1023 seems somehow not work as expected. 2: The log window in Progress is ways to small. I would estimate 10 lines would give enough context. 3. Buttons are untranslated. That rises the question from me: Bob, do you know any reasons, why we do not use the standard buttons, where applicable? 4. I would prefer, if Labels of Input fields (and buttons) would use underlines.
What do you mean with point 4 ? That the accelerator key on a button or input field label is underlined ?
Geert, the following dialogs are without use_underline on the labels of the input fields: Password Template Transaction If nobody objects, I will apply accelerators on the input label and apply standard buttons, where possible.
Sounds like a good plan.
Niggle: Underlined letters in a label are "mnemonics" (see the third subsection under Description in https://developer.gnome.org/gtk3/stable/GtkLabel.html), not "accelerators" (see https://developer.gnome.org/gtk3/stable/gtk3-Keyboard-Accelerators.html).
(In reply to Frank H. Ellenberger from comment #6) > I got a first answer: > https://lists.gnucash.org/pipermail/gnucash-de/2019-May/010609.html > > 1. Requested in Bug 679357 before: The TAN field should not be of type > password. > Transaction Authentication Numbers are these days only for a very short time > valid. It seems > https://github.com/Gnucash/gnucash/blob/maint/gnucash/import-export/aqb/gnc- > gwen-gui.c#L1019--L1023 seems somehow not work as expected. That is the visibility of the entry widget not the visibility of the entry, needs setting in the glade file. > 2: The log window in Progress is ways to small. I would estimate 10 lines > would give enough context. This will need expansion parameters and probably a height setting in the glade file. > 3. Buttons are untranslated. That rises the question from me: Bob, do you > know any reasons, why we do not use the standard buttons, where applicable? That was to do with removing all the button icons to be consistent as gtk-stock is depreciated and will be removed at some point. > 4. I would prefer, if Labels of Input fields (and buttons) would use > underlines. Did not add any as they were not there to start with. Do you want me to change any thing?
Just a follow up, not that I know any thing about translations, the text on the buttons I thought was pretty standard and as such would already of been translated somewhere, does it not just get the translation from there ?
I just commited standard buttons and mnenoics. Bob, yes, "_Cancel" etc. are in gnucash.pot and most translations, but the respective property in the glade file needs the translatable="yes" attribute, so the program knows, it should try to replace the text. About Gtk-stock is deprecated, I found this article: https://stackoverflow.com/questions/36805505/gtk-stock-is-deprecated-whats-the-alternative So the new standard for the names is https://specifications.freedesktop.org/icon-naming-spec/icon-naming-spec-latest.html Gtk-stock had 2 benefits: 1. translations of buttons was already done in the gtk domain. 2. Association of an icon. gtk_icon_factory... suggests to use GtkIconTheme instead. So somebody has to research, how to load the default icon style etc. and then use freedesktop names of thee buttons.
I would prefer them to be set translatable, I must of missed that tick in the box so that they are consistent with the rest. Later on a decision can be made for any buttons that should also have an icon and change the lot, not many I'm sure as I think I read some where a move towards buttons with no icons, I think there is also a gtk setting involved.
Christian Wehling reported, it was fixed by Commit 5846543, which is already in Gnucash 3.6
