GnuCash
Contact   Instructions
Bug 797204 - qif import: commodities throw blocking dialog in symbol field on every commodity
Summary: qif import: commodities throw blocking dialog in symbol field on every commodity
Status: RESOLVED FIXED
Alias: None
Product: GnuCash
Classification: Unclassified
Component: Import - QIF (show other bugs)
Version: 3.5
Hardware: PC All
: Normal normal
Target Milestone: ---
Assignee: import
QA Contact: import
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-04-18 15:37 EDT by Dale Phurrough
Modified: 2019-05-25 16:03 EDT (History)
4 users (show)

See Also:


Attachments
import_block_o_plenty.png (166.14 KB, image/png)
2019-04-18 15:37 EDT, Dale Phurrough
no flags Details

Description Dale Phurrough 2019-04-18 15:37:31 EDT
Created attachment 373246 [details]
import_block_o_plenty.png

When importing QIF, every commodity throws blocking dialog when you type the first character in the symbol field. This is extreme UI churn with no benefit.

===Setup:
GnuCash 3.5
Windows 10
Fresh gnucash file

===Repo
1. Export from Quicken a QIF file that has 20+ stocks in an investment account and transactions with them
2. In gnucash, choose file/import
3. Select that QIF file
4. Follow through the import wizard until you get to the section to "Enter information about..." the 20+ stocks.
5. Tab or click into the symbol field for the first stock

===Result
A blocking dialog that provides no new information and is not actionable. The text of that dialog is...

  Enter the ticker symbol or other well known abbreviation,
  such as "RHT". If there isn't one, or you don't know it,
  create your own.

This is the same text that appears as a tooltip. Therefore redundant.
In addition, this blocking dialog appears on every commodity of the import.
If you are importing 20+ stocks
...click or tab to the symbol field
...type the first character of the symbol
...you will see and be blocked with this dialog
...have to dismiss the blocking dialog
...and go back to the symbol field
...and continue typing the symbol
...repeated 20+ times  :-(

===Expected
No dialog to appear when I type in the symbol field.

===Notes
I recommend this blocking dialog be completely removed.
It already exists as a tooltip. Great place for it to remain :-)
If there is desire to have this text...somewhere...then it can be placed as static help text on the page near the symbol field or its label. However, I do not recommend that.

Screenshot attached: import-block-o-plenty.png
Comment 1 Bob 2019-04-26 11:45:48 EDT
Were the two fields populated to start with ?

I can get the error message when I delete the contents in preparation to enter a correct Ticker symbol or Name, it does seem a bit redundant as the next button is greyed out when the fields are blank.

I will look at this when I try to figure out a better interface for this part of the QIF import as you get a page for every stock/mutual fund and if you have a lot you loose the buttons of the screen.

I see you have a few but still managed to keep the buttons on screen.
Comment 2 Dale Phurrough 2019-04-26 13:48:05 EDT
Yes both were populated from the QIF file (the 'Y' field).

=====More repo steps detail
1. Import an investment QIF via the Wizard
2. Arrive at step "Accounts and stock holdings"
3. Click Next
4. UI presents dozens of accounts and stocks; both new and existing
5. Click Next
6. UI presents: US Dollar
7. Click Next
8. Wizard dynamically increases size to have all the new stocks
9. Click Next

====Result
Page of wizard appears with the 1st stock
Name or description: MyCompany Inc
Ticker symbol or other abbreviation: MyCompany Inc
Exchange or abbreviation type: FUND

===More repo
10. Tab into 2nd field (ticker symbol)
11. Type MSFT

===Result
An app model dialog appears after typing the 'M'
     "Enter the ticker symbol or..."

===More repo
12. Click close on the modal dialog
13. Continue typing 'SFT'
14. Click Next
15. Use the mouse to highlight all the text in the 2nd field (ticker symbol)
16. Press backspace or delete key

===Result
An app modal dialog appears after typing the 'M'
     "Enter the ticker symbol or..."

===Expected
No app modal dialog.

===Notes
Like you, I had some ideas myself on this step. I have formal experience in spec'ing workflows like this; drawing mockups, flowcharts, etc. Not a graphic designer, instead program mgr and dev. Perhaps I can contribute to your discussion on this.

My initial import was impossible, too many investments, the wizard was un-navigatible. I broke it down to blocks of years and stacked virtual desktops to fit a year "onscreen".  Technically....it worked. ;-)
Comment 3 Dale Phurrough 2019-04-26 13:50:00 EDT
Correction in result after step 16...

===Result
An app modal dialog appears after pressing the backspace or delete key
     "Enter the ticker symbol or..."
Comment 4 Bob 2019-05-13 05:02:20 EDT
This bug has two elements, the first is that when you have a large number of tradable commodities you get an assistant page for each one and if too many you loose site of the assistant buttons. To fix this a notebook was added to the tradable commodities assistant page with the individual commodities being added to notebook pages.

The second part was that when editing these an intrusive dialogue was being raised that displayed the same information as the tooltip which blocked input. These were removed and the assistant next button enabled when all entries are valid.

These changes will be in 3.6
Comment 5 Dale Phurrough 2019-05-16 16:37:08 EDT
The blocking dialog is gone. Thanks for your effort on this.

Tested on
- Archlinux (rolling as of 16 May 2019)
- Ubuntu 16.04
- Debian 9

With commit c38c4557a56370a51236903e326f4429fd5b2caf
Comment 6 John Ralls 2019-05-16 17:02:58 EDT
You reported this on Windows. If you're going verify you should test on the same platform as the report.
Comment 7 Dale Phurrough 2019-05-16 18:55:59 EDT
Agreed. I'll continue to test bugs using the Linux build pipelines that are ready and update the bugs while keeping them RESOLVED. This can provide reasonable test coverage for devs now rather than some unknown future when/if the Windows pipeline is working.

That, or I can change the bug to be for the Linux platform since many/all of the bugs exist identically on Linux.

Do you have a preference if the bug exists identically on both platforms?
Comment 8 John Ralls 2019-05-16 20:05:01 EDT
If the bug reproduces on more than one platform then set platform to "all".

What "pipeline" are you referring to?
Comment 9 Dale Phurrough 2019-05-25 15:33:18 EDT
changed platform/hardware to all as recommended
Build pipelines: meaning the automated process using docker for clean builds of gnucash
Comment 10 John Ralls 2019-05-25 16:03:38 EDT
OK, your own dev setups. Since that's meaningful only to you, best to just use the OS/distro and version (e.g. "Stretch", "F29", "Sierra", "Win10") in public.

Note You need to log in before you can comment on or make changes to this bug.