GnuCash
Contact   Instructions
Bug 797183 - head path for txn file association with blanks not found on Windows
Summary: head path for txn file association with blanks not found on Windows
Status: RESOLVED FIXED
Alias: None
Product: GnuCash
Classification: Unclassified
Component: Windows (show other bugs)
Version: 3.5
Hardware: PC Windows
: Normal normal
Target Milestone: ---
Assignee: windows
QA Contact: windows
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-04-07 08:55 EDT by Jannick
Modified: 2019-04-14 05:03 EDT (History)
4 users (show)

See Also:


Attachments
associated files window with head path with blanks (48.10 KB, image/jpeg)
2019-04-07 08:55 EDT, Jannick
no flags Details

Description Jannick 2019-04-07 08:55:26 EDT
Created attachment 373233 [details]
associated files window with head path with blanks

In case the path head for transaction association files contains blanks, then

- the head path displayed under 'tools > transaction assocations' appears not to be URL-decoded (blanks shown as '%20',see attachment)
- and is said to not exist (false negative in my case)

Wildly guessing the issue might be potentially fixed if the head path is URL-decoded.

I have not checked if the column entries 'available' and 'relative' are impacted by this issue.

This is probably a Windows only issue, as blanks are not prohibited in paths on Windows. This is why I selected 'Windows' as component of this ticket. Please do feel free to amend, of course.
Comment 1 Bob 2019-04-08 07:29:24 EDT
I will look at this...
Comment 2 Jannick 2019-04-09 04:42:23 EDT
Separately, another bug which is potentially related to the first one: 

Still the head path does have blanks. While the path WITH blanks to an EXISTING associated document is displayed with decoded blanks in the column 'association', GC claims not to find the file (column 'available?'). However, double-clicking the file path does open the file. This happens independently of what column 'relative' shows (on and off).
Comment 3 Bob 2019-04-12 09:55:45 EDT
I have pushed a fix and will be in the next nightly if you could try that would be great.
Comment 4 Jannick 2019-04-13 07:28:57 EDT
Many thanks!  After installing nightly gnucash-3.5-2019-04-13-git-3.5-27-g0f6465ca6+.setup.exe, the head path is now properly displayed and signaled as being found.  Great!


Additional points/issues I encountered working with the useful association window:

1 - When opening the association window, column 'avaliable?' says 'unknown' for each association, while - in my case - for some of the lines 'relative' shows TRUE. 

2 - Hitting then button 'locate association' makes GC check if each file association exists - not the highlighted one only as suggested by the button text.

3 - To update a (probably not existing) file path, the user currently needs to jump to the transaction window, then change the file path there. When going back to the association window, there is currently no refresh feature. So the user needs to close the window and open the association window again to check if the changes made are fine.

4 - the text of button 'Close' is not translated when I am opening GC with the German locale (de_DE).


Some additional suggestions to enhance the usability of this report:

a - populate the column 'available?' upon opening the association window.

b - if 'relative' is set to TRUE, couldn't the relative file path be displayed? (I am currently not sure how the user could use this info.)

c - change the button text 'locate association' to 'locate associations' or apply the location procedure to the highlighted row(s) only. See d.

d - c could benefit if multiple lines could be selected.

e - add a button 'refresh' to retrieve the data for the table again and update it.

f - add a button - or another event - to update the file path from the association window.

g - the text of button 'close' should be captured by translations.

h - add the sorting feature for every column (from bug 797185 to collect things in one single list / ticket).

Very happy to test.  Many thanks!
Comment 5 Bob 2019-04-14 05:03:08 EDT
Marking this as fixed and moved the above text to bug 797185.

Note You need to log in before you can comment on or make changes to this bug.