When using the Add button in the Price Database, the Price Editor dialog is pre-populated with the Security and Date of any highlighted row. If the user does not modify the Date, the existing price will be overwritten whether or not this was the intention. User should be prompted any time the Add button is not effectively adding, but will instead overwrite existing data.
v3.5 has the same bug, but adds the additional problem of NOT displaying the new value until the Price Database window is reopened.
PR 495 created with a possible fix.
I pushed a fix for this and will be in the next nightly windows build if you would like to confirm.
In 3.5-126 if I try to click Add and then only change the default price, I get an AYS dialog. If I click Edit and do the same, I do not get the AYS dialog. So the program does warn me now. Is this the desired fix? Should the Add and Edit buttons normally do the exact same thing?
Don't you expect that if you're editing an existing price that it would change that price rather than create a new one? Wouldn't the AYS dialog be pretty annoying in that case? I notice that if a quote is selected when you click Add that the dialog comes up already filled in with that quote's information, just as if you'd clicked Edit while if you highlight the heading it comes up with today's date and a blank price. That strikes me as unintuitive and error prone: Add should always come up for today with a blank price.
That's what I meant. Exactly.
Made another change and for new prices the date will be reset to today and the price will be 0 just like a heading row. Should be in the next nightly if you would like to check so this can be closed.
3.5-170 works much better. My only nit pick is the AYS cancel button dismisses the Add dialog.
Changed this so that when you cancel the AYS it returns to the 'Price Editor' Will be in release 3.6
