GnuCash
Contact   Instructions
Bug 797029 - Import Customer & Vendors: blank name and company in import data row crashes GnuCash
Summary: Import Customer & Vendors: blank name and company in import data row crashes ...
Status: RESOLVED FIXED
Alias: None
Product: GnuCash
Classification: Unclassified
Component: Import - CSV (show other bugs)
Version: git-maint
Hardware: PC Mac OS
: Normal normal
Target Milestone: ---
Assignee: Rob Laan
QA Contact: import
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-01-08 13:39 EST by Rob Laan
Modified: 2019-03-29 18:00 EDT (History)
3 users (show)

See Also:


Attachments
Import file to illustrate the bug (88 bytes, text/plain)
2019-01-08 13:41 EST, Rob Laan
no flags Details

Description Rob Laan 2019-01-08 13:39:29 EST
In the function Import Customers & Vendors, when both the company and name import data fields are blank, the data row should be ignored.

For that reason, on line 248 of dialog-customer-import.c, the data row is removed from the GtkListStore. But current code does not use the return value of gtk_list_store_remove to set the loop control variable 'valid'.

So 'valid' remains true, the loop continues, and when the next line is read with the iterator pointing to nowhere, GnuCash crashes.
Comment 1 Rob Laan 2019-01-08 13:41:25 EST
Created attachment 373115 [details]
Import file to illustrate the bug

Vendor import file with name and company set to blank. Crashes GnuCash.
Comment 2 John Ralls 2019-03-29 18:00:55 EDT
This is fixed and will be released in GnuCash 3.5. Thanks for the report.

Note You need to log in before you can comment on or make changes to this bug.