Created attachment 373072 [details] screenshot of the gui The underscore is visible in the GUI as can be seen on the screenshot. _Rechnung and _Zahlung. The underscore exists in the po-file de.po. msgid "View/Edit Invoice" msgstr "_Rechnung anzeigen/bearbeiten" and msgid "_Process Payment..." msgstr "_Zahlung verarbeiten..." I don'tknow what the underscore is about, but it certainly shouldn't be visible in the gui.
If the button was setup to use a mnemonic accelerator key the underscore in front of the letter would be the key to use with the 'Alt' key. You can see this by holding down the 'Alt' key in the search dialogue and looking at the 'Find' button and in the po file that is '_Suchen...' so that is 'Alt+S'. The buttons on the end have not been setup for this so the translation is wrong. If the text is right, all that needs to be done is remove the '_' from these two strings.
Wouldn't it be better to fix the button instead ?
Yes
Is this specific to the business buttons or are all buttons ignoring the underscores ?
We are not deliberately ignoring underscores as far as I know. But if the original message ID doesn't have an underscore to mark an accelerator, the translated ID can't have it either. Note that in your original message above you have selected the wrong msgid for "Process Payment..." There's another one in the po file without the underscore (line 1475 in current maint's po file), but the German translation still has it. So if you want to fix the buttons it suffices to fix the original strings in the code that will be used by these buttons. The accelerator should be chosen carefully not to collide with existing accelerators in the same dialog window.
Thanks Geert ! I see that I took the "_Zahlung verarbeiten" String from line 3566. So to fix this I have to assure that the translation doesn't have an underscore if the original doesn't. So either add to the original language or remove in the translation.
Couldn't that be automated and raise a warning ?
(In reply to Christoph Holtermann from comment #7) > Couldn't that be automated and raise a warning ? msgfmt -c --check-accelerators="_" --statistics de.po generates the warnings at least in the other direction. Some background: When I did the translation of 2.6, I did also a review of the GUI for missing or desirable mnemonics. But with the switch to version 3 several parts got lost: Some in the translation and some in the GUI. After that frustration I did not find the time to redo and continue that task. So, if you find such strings, improve the GUI instead of reverting de.po. A similar issue are hellipses (...) in menu entries if dialogs follow.
