GnuCash
Contact   Instructions
Bug 796965 - Show Unused Accounts
Summary: Show Unused Accounts
Status: RESOLVED FIXED
Alias: None
Product: GnuCash
Classification: Unclassified
Component: Budgets (show other bugs)
Version: 3.3
Hardware: PC Windows
: Normal normal
Target Milestone: ---
Assignee: core
QA Contact: core
URL:
Whiteboard:
Keywords:
: 796990 (view as bug list)
Depends on:
Blocks:
 
Reported: 2018-12-03 08:55 EST by Robin
Modified: 2019-02-09 02:52 EST (History)
4 users (show)

See Also:


Attachments

Description Robin 2018-12-03 08:55:00 EST
The check box 'Show Unused Accounts' on the budget screen has to be ticked each time the budget is accessed.
Would it be possible for the user choice to be kept similar to the way it works on the accounts screen.
Comment 1 Bob 2018-12-21 05:13:20 EST
I have changed the default to show unused accounts in PR442. The value is saved as part of saving the page when it is open on exit just like the accounts page. If you close the budget page and then reopen it you will get the default setting which will show the unused accounts.

Hopefully this will get added in time for 3.4, just need to see if it is accepted.
Comment 2 Geert Janssens 2018-12-22 12:02:56 EST
As you hinted in the commit comment, this change is only part of the gui's save state, not the budget itself.

One step back: I can valid used cases for both defaults.
Not showing unused accounts by default makes sense when the user is mostly consulting a previously set up budget or when the budget is covering only a small subset of the available accounts.
On the other hand showing unused accounts by default is more user friendly when the user is frequently adding budget data to still unused accounts.

By flipping the default for unused accounts when opening a budget report, you are now transferring the annoyance from users in the second group to users in the first group :(

If we commit this as is you can expect a bug report for the opposite case. I have been there in the past with similar changes.

So I think the proper solution is as you already guessed: make it a budget level option which accounts to show. If we can add this in a way that that budget can still be read in older versions of gnucash (albeit by ignoring the option) it can go in the 3.x series, otherwise it will have to go into 4.x.
Comment 3 Bob 2018-12-22 13:22:41 EST
I have dropped this from the PR, will think about it.
Comment 4 Robin 2018-12-26 14:27:10 EST
Hi guys thank you for looking at this. The problem is not the default but the fact if you change the setting and save it when you next access the budget your choice has not been saved. Is it possible to amend one of the files to stop this from happening?
Comment 5 Geert Janssens 2018-12-27 03:20:30 EST
I think that should be possible: we could choose to save state for each budget regardless of whether it's currently open or not. We do the same for registers. This state is saved in the metadata file.

To be clear we currently don't do this for budgets. My suggestion is we could in the future.
Comment 6 Geert Janssens 2019-01-31 12:18:33 EST
Bob has written a patch for the budgetting code such that
a. budgets will show unused accounts by default
b. The user can override this per budget via View->Filter By...
c. the user preference will be saved and restored when reopening the book

This patch will be part of gnucash 3.5
Comment 7 Robin 2019-01-31 14:41:42 EST
Thanks Bob, much appreciated, great product.
Comment 8 Geert Janssens 2019-02-09 02:52:30 EST
*** Bug 796990 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.