GnuCash
Contact   Instructions
Bug 796960 - [HBCI transaction import dialog] purely lexicographic sorting of columns DATE and AMOUNT
Summary: [HBCI transaction import dialog] purely lexicographic sorting of columns DATE...
Status: RESOLVED FIXED
Alias: None
Product: GnuCash
Classification: Unclassified
Component: Import - AqBanking (show other bugs)
Version: 3.3
Hardware: PC Windows
: Normal normal
Target Milestone: 3.4
Assignee: import
QA Contact: import
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-12-01 08:39 EST by Jannick
Modified: 2018-12-10 02:25 EST (History)
5 users (show)

See Also:


Attachments
HBCI txn import dialog: column AMOUNT sorted (13.90 KB, image/jpeg)
2018-12-01 10:19 EST, Jannick
no flags Details

Description Jannick 2018-12-01 08:39:58 EST
HBCI transaction import dialog window: 

Sorting the columns DATE and AMOUNT follows the ordinary string comparison applied to the date/amount strings as displayed (display stype depends on configuration):

- column DATE - example of sorted column with date display style 'dd.mm.yyyy':

01.01.2018
01.02.2017
31.12.2018

expected (lexicographic order acc. to 'yyyymmdd'):
01.02.2017
01.01.2018
31.12.2018


- column AMOUNT - the ordinary lexicographix order is applied to the strings showing the amounts (incl. sign and currency symbol). Example of sorted column AMOUNT:

10,00 EUR
2,00 EUR
20,00 EUR

expected:
2,00 EUR
10,00 EUR
20,00 EUR
Comment 1 Jannick 2018-12-01 08:40:26 EST
Potentially relevant: https://bugs.gnucash.org/show_bug.cgi?id=435427
Comment 2 Bob 2018-12-01 09:24:59 EST
This is already fixed and will be in the 3.4 relaese, see bug 793156
Comment 3 Bob 2018-12-01 09:27:08 EST
Sorry I think this is some thing different...
Can you provide a screen shot, obscure any thing personal.
Comment 4 Jannick 2018-12-01 10:19:16 EST
Created attachment 373071 [details]
HBCI txn import dialog: column AMOUNT sorted

This is the same issue as in bug 793156, but a different import window.

I just installed the nightly build gnucash-3.900-2018-12-01-git-3.3-159-g6eba0d494+.setup.exe:

- column DATE issue fixed

- column AMOUNT issue still present, see attachment (showing the sorted AMOUNT column, word "Betrag" means "Amount")
Comment 5 Bob 2018-12-02 15:07:52 EST
Created a possible fix in PR436, waiting for approval.
Comment 6 Frank H. Ellenberger 2018-12-10 01:28:55 EST
This was fixed in commit 51ab6e7 of PR #436, which got merged in commit 9921ab2.
Comment 7 Jannick 2018-12-10 02:25:06 EST
(In reply to Bob from comment #5)
> Created a possible fix in PR436, waiting for approval.

(In reply to Frank H. Ellenberger from comment #6)
> This was fixed in commit 51ab6e7 of PR #436, which got merged in commit
> 9921ab2.
Great! Many thanks for looking after this.

Note You need to log in before you can comment on or make changes to this bug.