GnuCash
Contact   Instructions
Bug 796945 - Find Transaction Split Search Search Criteria window does not scroll when added criteria exceed a certain amount
Summary: Find Transaction Split Search Search Criteria window does not scroll when add...
Status: RESOLVED FIXED
Alias: None
Product: GnuCash
Classification: Unclassified
Component: User Interface General (show other bugs)
Version: git-maint
Hardware: PC Linux
: Normal normal
Target Milestone: ---
Assignee: ui
QA Contact: ui
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-11-10 21:36 EST by killsap
Modified: 2019-11-04 05:47 EST (History)
6 users (show)

See Also:


Attachments
Search criteria cutoff. (222.56 KB, image/png)
2018-11-10 21:36 EST, killsap
no flags Details
Screen shot showing the find results problem (991.23 KB, image/png)
2019-01-02 00:31 EST, Mike Alexander
no flags Details

Description killsap 2018-11-10 21:36:27 EST
Created attachment 373058 [details]
Search criteria cutoff.

In the Find Transaction Split Search, Search Criteria, window (CTRL-F) you can add criteria which will extend the window height. The window height can be extended, by adding criteria, past your monitor height essentially cutting off the bottom buttons.

Solution:
Put the Search Criteria elements in a GTK scrolled container.
Comment 1 killsap 2018-11-11 17:06:50 EST
I have a fix for this:

I added the criteria_table to a Viewport and the Viewport to a ScrolledWindow where:

1) Propagate Natural Height is on
2) Shadow type is Etched in
3) Kinetic Scrolling is true
4) Minimum content height is set to 5
5) Scrollbar Policy: Horizontal=never & Vertical=automatic
6) Shadow type of Viewport = Etched in
Comment 2 John Ralls 2018-11-12 03:57:36 EST
Sounds reasonable. https://wiki.gnucash.org/wiki/Development#Submitting_Patches.
Comment 3 John Ralls 2018-12-25 14:18:26 EST
Bob Fewell contributed a fix as part of https://github.com/Gnucash/gnucash/pull/442, which has been merged and will be included in GnuCash 3.4.
Comment 4 Mike Alexander 2019-01-02 00:28:47 EST
After this fix the search results window for Business->Customer->Find Invoice is formatted incorrectly.  The top 3/4 or so is blank and all the results are in a small section at the bottom of the window.  It looks like the bottom part is sized so the buttons at the right fit and the rest of the window is blank.  Reverting 952761a fixes this problem.
Comment 5 Mike Alexander 2019-01-02 00:31:16 EST
Created attachment 373091 [details]
Screen shot showing the find results problem
Comment 6 Bob 2019-11-04 05:47:31 EST
Unfortunately I did not see this as I would of looked at it earlier. I have pushed a fix for this so that the search criteria will only use the minimum amount of space. This change will show 5 rows of search criteria before the scrollbars kick in and so limiting the space needed for the search criteria. The rest of the vertical space is left for the search results.

This will be in the next release 3.8

Note You need to log in before you can comment on or make changes to this bug.