GnuCash
Contact   Instructions
Bug 796737 - Patch to restore gncmod-python.c.
Summary: Patch to restore gncmod-python.c.
Status: RESOLVED FIXED
Alias: None
Product: GnuCash
Classification: Unclassified
Component: Engine (show other bugs)
Version: 3.2
Hardware: PC Mac OS
: Normal enhancement
Target Milestone: future
Assignee: core
QA Contact: core
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-07-05 07:32 EDT by David
Modified: 2018-07-07 16:37 EDT (History)
4 users (show)

See Also:


Attachments
git diff -p patch file (9.35 KB, application/octet-stream)
2018-07-05 07:32 EDT, David
no flags Details

Description David 2018-07-05 07:32:01 EDT
Created attachment 372906 [details]
git diff -p patch file

This patch restores the gncmod-python.dylib engine module.
The patch is against release tag 3.2.

It removes the need to link the module to libgncmod-app-utils.dylib or libgncmod-core-utils.dylib. This was needed previously as the init function for those modules was called in the c code. However, unless there was python c code at some point in gncmod-python.c to use functions in c of either core utils or app utils these are not needed. Those module init functions would be called when the modules are imported in eg init.py, which does indeed import _sw_app_utils successfully.

I have made edits to init.py (and other files) so it loads without errors with python 3. These edits are NOT tested. I dont actually use pycons, I update the init.py to simply import my python subsystem init module. I never set the if False: to if True: to actually activate the console.


This is all done on OSX using X11 (XQuartz) version and macports system to build.
Comment 1 John Ralls 2018-07-07 16:37:08 EDT
Committed and pushed, using your comment as the commit message. Thanks.

If you do another patch, please commit it first with a good commit message and make the patch with `git format-patch` OR fork GnuCash on Github and make a pull request.

Note You need to log in before you can comment on or make changes to this bug.