796669 – Dark Theme Text Colors Hard to Read

Bug 796669 - Dark Theme Text Colors Hard to Read

Summary: Dark Theme Text Colors Hard to Read

Status:	RESOLVED FIXED

Alias:	None

Product:	GnuCash
Classification:	Unclassified
Component:	User Interface General (show other bugs)
Version:	3.1
Hardware:	Other Windows

Importance:	Normal normal
Target Milestone:	future
Assignee:	ui
QA Contact:	ui

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2018-06-25 11:46 EDT by michael
Modified:	2018-07-15 13:56 EDT (History)
CC List:	7 users (show)

See Also:

Attachments
Register Screenshot (34.17 KB, image/png) 2018-06-25 11:46 EDT, michael	no flags	Details
View All Add an attachment (proposed patch, testcase, etc.)

Description michael 2018-06-25 11:46:19 EDT

Created attachment 372817 [details]
Register Screenshot

When using a dark theme in v3.2, the text is "black on dark."  This occurs when you are not using the build-in colors.

According to Geert, GNC should auto-detect a dark theme and adjust accordingly.

I'm on windows 10 and my gtk-3.0\settings.ini file has the following:

[Settings]
gtk-application-prefer-dark-theme=true
gtk-theme-name=Adwaita

I'm happy to help test so please let me know how I can help.

Michael

Comment 1 Bob 2018-06-25 17:54:32 EDT

I will have a look at this.

Comment 2 Alen Siljak 2018-06-26 08:56:29 EDT

Ah, OK, at least there's a workaround. Using Settings / Register / Graphics / Use GnuCash built-in color theme looks good with the dark theme.

Comment 3 Bob 2018-07-15 12:18:50 EDT

Possible fix in PR383.
With this change when using 'not use the built in colours' the foreground colour should be that of the theme. It still requires the user to adjust any foreground/background colour combinations for the transaction and splits as mentioned in the Wiki.

Comment 4 John Ralls 2018-07-15 13:56:24 EDT

Bob's change is pushed and will be in 3.3.

Note You need to log in before you can comment on or make changes to this bug.